chore: remove instanceset's role probe #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8578 +/- ##
==========================================
+ Coverage 60.25% 60.81% +0.56%
==========================================
Files 377 377
Lines 45849 45639 -210
==========================================
+ Hits 27626 27757 +131
+ Misses 15623 15301 -322
+ Partials 2600 2581 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cjc7373
requested review from
free6om,
a team,
leon-inf and
Y-Rookie
as code owners
free6om
approved these changes
Dec 5, 2024
zjx20
reviewed
Dec 5, 2024
leon-inf
reviewed
Dec 5, 2024
leon-inf
reviewed
Dec 5, 2024
leon-inf
reviewed
Dec 5, 2024
leon-inf
reviewed
Dec 5, 2024
leon-inf
reviewed
Dec 5, 2024
cjc7373
force-pushed
the
support/remove-its-role-probe
branch
from
844df0d to
3b8fbbc
Compare
leon-inf
reviewed
Dec 10, 2024
| @@ -52,7 +52,7 @@ var _ = Describe("pod role label event handler test", func() { | |||
| Namespace: pod.Namespace, | |||
| Name: pod.Name, | |||
| UID: pod.UID, | |||
| FieldPath: readinessProbeEventFieldPath, | |||
| FieldPath: lorryEventFieldPath, | |||
There was a problem hiding this comment.
lagacyReadinessProbeEventFieldPath?
There was a problem hiding this comment.
This test tests PodRoleEventHandler's behaviour. IMO It doesn't matter which fieldpath to use.
leon-inf
approved these changes
Dec 10, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit ad4c4c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's not used anywhere. Also closes #7720