Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check lifecycle actions to avoid NPE when calling actions during scale-in #8762

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Jan 8, 2025

fix #8754

@leon-inf leon-inf added this to the Release 1.0.0 milestone Jan 8, 2025
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners January 8, 2025 08:41
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (fd21c31) to head (6be9263).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/transformer_component_workload.go 60.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8762      +/-   ##
==========================================
+ Coverage   60.50%   60.68%   +0.17%     
==========================================
  Files         378      378              
  Lines       45955    45968      +13     
==========================================
+ Hits        27807    27896      +89     
+ Misses      15505    15433      -72     
+ Partials     2643     2639       -4     
Flag Coverage Δ
unittests 60.68% <60.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 9, 2025
@leon-inf leon-inf merged commit 18f1121 into main Jan 10, 2025
39 checks passed
@leon-inf leon-inf deleted the bugfix/npe-at-switchover branch January 10, 2025 01:30
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12701555970

apecloud-bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ScaleIn Instance without specifying lifeCycleActions causing panic
4 participants