fix: NPE when adding a new service port #8803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-inf
requested review from
nayutah,
ldming,
heng4fun,
free6om and
wangyelei
as code owners
shanshanying
approved these changes
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.8 #8803 +/- ##
===============================================
+ Coverage 65.14% 65.31% +0.17%
===============================================
Files 307 307
Lines 38516 38523 +7
===============================================
+ Hits 25090 25162 +72
+ Misses 11229 11164 -65
Partials 2197 2197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Y-Rookie
reviewed
Jan 14, 2025
| // TODO: how about the order changed? | ||
| servicePorts := make(map[string]corev1.ServicePort) | ||
| for i, port := range obj.Ports { | ||
| servicePorts[port.Name] = obj.Ports[i] |
There was a problem hiding this comment.
port.Name is optional and omitempty？
There was a problem hiding this comment.
Change to use the port as the hash key.
|
@Y-Rookie PTAL |
leon-inf
force-pushed
the
bugfix/npe-when-adding-service-port
branch
from
8fdf0b8 to
b298eaf
Compare
zjx20
approved these changes
Jan 16, 2025
Y-Rookie
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8802