chore: support resolving vars from multiple components consistently #8816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relevant issues: |
leon-inf
force-pushed
the
support/resolve-vars-from-sharding-components
branch
from
9775af9 to
6c846eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8816 +/- ##
==========================================
+ Coverage 60.34% 60.99% +0.65%
==========================================
Files 381 382 +1
Lines 46215 46900 +685
==========================================
+ Hits 27889 28608 +719
+ Misses 15654 15611 -43
- Partials 2672 2681 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
force-pushed
the
support/resolve-vars-from-sharding-components
branch
from
6c846eb to
8edcabe
Compare
leon-inf
force-pushed
the
support/resolve-vars-from-sharding-components
branch
from
8edcabe to
f1017e3
Compare
github-actions
bot
added
size/XL
zjx20
approved these changes
Jan 16, 2025
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (r *ShardingDefinitionReconciler) requireParallelProvision() bool { |
There was a problem hiding this comment.
Please add some comments to explain why parallel provisioning is needed when some of the RequireAllComponentObjects fields are set to true.
|
/approve |
apecloud-bot
approved these changes
Jan 21, 2025
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close apecloud/kubeblocks-addons#1416