Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE when adding a new service port #8819

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

leon-inf
Copy link
Contributor

fix #8802

@leon-inf leon-inf requested review from Y-Rookie and a team as code owners January 17, 2025 02:08
@leon-inf leon-inf added this to the Release 0.9.3 milestone Jan 17, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.67%. Comparing base (b5d3380) to head (1b99d53).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
controllers/apps/transformer_cluster_service.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8819      +/-   ##
===============================================
+ Coverage        64.44%   64.67%   +0.23%     
===============================================
  Files              359      359              
  Lines            46381    46387       +6     
===============================================
+ Hits             29889    30003     +114     
+ Misses           13807    13712      -95     
+ Partials          2685     2672      -13     
Flag Coverage Δ
unittests 64.67% <85.71%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 17, 2025
@leon-inf leon-inf merged commit b20e67d into release-0.9 Jan 17, 2025
38 checks passed
@leon-inf leon-inf deleted the bugfix/npe-when-adding-service-port branch January 17, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KubeBlocks 0.8.4 Crashes After Updating SVC to Existing Clusters.
3 participants