Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE when adding a new service port #8820

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

leon-inf
Copy link
Contributor

fix #8802

@leon-inf leon-inf added this to the Release 1.0.0 milestone Jan 17, 2025
@leon-inf leon-inf requested a review from a team as a code owner January 17, 2025 02:13
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (982672d) to head (ce23e4f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/component/utils.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8820      +/-   ##
==========================================
+ Coverage   60.34%   60.52%   +0.17%     
==========================================
  Files         381      381              
  Lines       46215    46216       +1     
==========================================
+ Hits        27889    27972      +83     
+ Misses      15654    15576      -78     
+ Partials     2672     2668       -4     
Flag Coverage Δ
unittests 60.52% <50.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 17, 2025
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit e8a2de1 into main Jan 20, 2025
40 checks passed
@leon-inf leon-inf deleted the bugfix/npe-when-adding-service-port-1.0 branch January 20, 2025 07:18
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12862923325

apecloud-bot pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KubeBlocks 0.8.4 Crashes After Updating SVC to Existing Clusters.
4 participants