Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to get ca-key file when enabling tls #8840

Closed
wants to merge 1 commit into from

Conversation

wangyelei
Copy link
Contributor

Some databases require mutual authentication, which means both the client and server must verify each other’s identity. In such cases, you need a CA (Certificate Authority) key file and a CA certificate to issue client certificates

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners January 21, 2025 09:14
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.10%. Comparing base (fbd2ea0) to head (940b62d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/plan/tls.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8840      +/-   ##
==========================================
+ Coverage   60.06%   60.10%   +0.03%     
==========================================
  Files         382      382              
  Lines       46123    46128       +5     
==========================================
+ Hits        27704    27724      +20     
+ Misses      15748    15726      -22     
- Partials     2671     2678       +7     
Flag Coverage Δ
unittests 60.10% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei closed this Jan 23, 2025
@github-actions github-actions bot added this to the Release 0.9.3 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant