fix: use update instead of patch to set pod's role #8865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8865 +/- ##
==========================================
+ Coverage 60.16% 60.35% +0.19%
==========================================
Files 382 382
Lines 46293 46293
==========================================
+ Hits 27850 27938 +88
+ Misses 15771 15688 -83
+ Partials 2672 2667 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
reviewed
Jan 24, 2025
github-actions
bot
added
size/M
Y-Rookie
approved these changes
Jan 24, 2025
zjx20
changed the title
leon-inf
reviewed
Jan 24, 2025
| @@ -123,6 +123,44 @@ var _ = Describe("pod role label event handler test", func() { | |||
| return nil | |||
| }).Times(1) | |||
| Expect(handler.Handle(cli, reqCtx, nil, event)).Should(Succeed()) | |||
|
|
|||
| By("read a stale pod") | |||
There was a problem hiding this comment.
Only explicitly mocked update conflicts are present, not a stale read scenario.
There was a problem hiding this comment.
By the way, such test cases have no practical significance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.