Skip to content

Commit

Permalink
Merge 3.4 (#6507)
Browse files Browse the repository at this point in the history
* tests: remove output suffix after reverting

* cs: remove unnecessary comments (#6408)

* fix(elasticsearch): change normalize return type to compatible with other normalizers (#6493)

* style: various cs fixes (#6504)

* cs: fixes

* chore: phpstan fixes

* style: cs fixes

---------

Co-authored-by: Takashi Kanemoto <[email protected]>
Co-authored-by: Koen Pasman <[email protected]>
  • Loading branch information
3 people authored Aug 9, 2024
1 parent 052f76b commit 3369873
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion AbstractCollectionNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ abstract class AbstractCollectionNormalizer implements NormalizerInterface, Norm
/**
* This constant must be overridden in the child class.
*/
// @noRector \Rector\Php81\Rector\ClassConst\FinalizePublicClassConstantRector
public const FORMAT = 'to-override';

public function __construct(protected ResourceClassResolverInterface $resourceClassResolver, protected string $pageParameterName, protected ?ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null)
Expand Down
1 change: 0 additions & 1 deletion JsonEncoder.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
*/
final class JsonEncoder implements EncoderInterface, DecoderInterface
{
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
public function __construct(private readonly string $format, private ?BaseJsonEncoder $jsonEncoder = null)
{
if (null !== $this->jsonEncoder) {
Expand Down

0 comments on commit 3369873

Please sign in to comment.