Update dependencies and readme, fix minor UI bug #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
changed the title
Siegrift
force-pushed
the
general-updates
branch
from
94f7d32 to
a5a65fd
Compare
|
@bbenligiray can you review af75b4e especially the part about updating the ENS names whether it's accurate? |
Siegrift
commented
Feb 5, 2022
| array: T[], | ||
| toInsert: ToInsert | ||
| ): ToInsert extends InsertInBetweenValue<T, infer R> ? Array<T | R> : Array<T | ToInsert> => { | ||
| export const insertInBetween = <Type, Delimeter>( |
There was a problem hiding this comment.
This was way overengeneered
andreogle
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been travelling so I decided to update the dependencies and update the README. I also fixed one minor UI bug and created #274 which I didn't want to fix as of now.