Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove homepage contract list, promote staking stats, adjust layout #122

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Jan 16, 2025

Closes #121 in preparation of adding incinerator stats. Before and after screenshots for convenience:

image




image

@dcroote dcroote self-assigned this Jan 16, 2025
@bbenligiray
Copy link
Member

I'm just looking at the screenshot, looks like a clear improvement to me. Some suggestions

  • Calling the epoch on the right "previous" doesn't feel right, so "Past Epoch" could be used instead of both instances of "Previous Epoch" (though I would defer to native speakers about this kind of stuff)
  • For the "Circulating Supply" and "Total Staked" sections to look more symmetric, we can do this instead
Circulating Supply Total Staked
Total Supply Staking Target

and to take that further so that totals are aligned

Total Supply Total Staked
Circulating Supply Staking Target

As a side effect this draws attention on the total supply rather than the circulating supply but personally I'm neutral on that.

Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me from a technical standpoint 🚀
It also generally looks better/visually makes more sense :)

@dcroote
Copy link
Contributor Author

dcroote commented Jan 22, 2025

Good suggestions @bbenligiray - all incorporated, see below:

image

@dcroote dcroote merged commit adae24a into main Jan 22, 2025
3 checks passed
@dcroote dcroote deleted the clean-homepage branch January 22, 2025 16:08
@dcroote dcroote mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove API3 smart contracts from homepage & promote Staking metrics
3 participants