Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipped Drupal check & rules version updated to 4.x for Drupal 10.3 #1083

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Skipped Drupal check & rules version updated to 4.x for Drupal 10.3 #1083

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86dfdb9
Ignore Drupal check to Apigee Edge module for Drupal 10.3
kedarkhaire Sep 20, 2024
42ec646
Rules condition changes
kedarkhaire Sep 24, 2024
02b89cb
Removed extra space
kedarkhaire Sep 24, 2024
4125a93
Merge branch '3.x' into issue-1079
kedarkhaire Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
drupal-core:
# Should update the following as the minimum supported version from Drupal.org
- "10.2.x"
- "10.3.x"
instance-type:
- "Edge"
- "X"
Expand Down Expand Up @@ -94,7 +95,6 @@ jobs:
composer config --no-plugins allow-plugins.cweagans/composer-patches true
composer config --no-plugins allow-plugins.php-http/discovery true
composer config minimum-stability dev
composer require 'drupal/rules:3.x-dev@dev'
composer require wikimedia/composer-merge-plugin
composer config --json extra.merge-plugin.require '["modules/contrib/apigee_edge/composer.json"]'
composer config platform.php ${{ matrix.php-version }}
Expand All @@ -104,6 +104,20 @@ jobs:
composer require --dev drupal/classy:^1.0
composer config --no-plugins allow-plugins.drupal/console-extend-plugin true

- name: "Allow plugins and dev dependencies for Drupal 10.2"
if: ${{ matrix.drupal-core == '10.2.x' }}
run: |
cd drupal
composer require 'drupal/rules:3.x-dev@dev'
composer update --with-all-dependencies

- name: "Allow plugins and dev dependencies for Drupal 10.3"
if: ${{ matrix.drupal-core == '10.3.x' }}
run: |
cd drupal
composer require 'drupal/rules:^4.0'
composer update --with-all-dependencies

# Install drupal using minimal installation profile and enable the module.
- name: Install Drupal
run: |
Expand All @@ -124,7 +138,8 @@ jobs:
echo "APIGEE_EDGE_ENDPOINT=$APIGEE_EDGE_HYBRID_ENDPOINT" >> $GITHUB_ENV
composer show > composer-show.txt

- name: "Drupal check"
- name: "Drupal check for Drupal 10.2"
if: ${{ matrix.drupal-core == '10.2.x' }}
run: |
cd drupal
vendor/bin/drupal-check modules/contrib/apigee_edge
Expand Down