Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post create team redirection and changed internal name as machine name #885

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Post create team redirection and changed internal name as machine name #885

merged 4 commits into from
Jul 17, 2023

Conversation

shishir-intelli
Copy link
Collaborator

@shishir-intelli shishir-intelli commented Jul 11, 2023 •
edited
Loading

  • Changed Internal name as Machine name
  • Following the team creation, user is redirected to manage the members and apps for that team.

b/289746352

@shishir-intelli shishir-intelli added the enhancement New feature or request label Jul 11, 2023
@shishir-intelli shishir-intelli added this to the 2.1.1 milestone Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #885 (85ff6b6) into 2.x (adcd4cf) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #885      +/-   ##
============================================
- Coverage     43.95%   43.91%   -0.04%     
- Complexity     3020     3021       +1     
============================================
  Files           342      342              
  Lines         11104    11114      +10     
============================================
  Hits           4881     4881              
- Misses         6223     6233      +10
Impacted Files Coverage Δ
...gee_edge_teams/src/Entity/Form/TeamAppEditForm.php 0.00% <0.00%> (ø)
...les/apigee_edge_teams/src/Entity/Form/TeamForm.php 0.00% <0.00%> (ø)
.../apigee_edge_teams/src/Form/AddTeamMembersForm.php 0.00% <0.00%> (ø)
src/Entity/Form/AppForm.php 0.00% <0.00%> (ø)

divya-intelli
divya-intelli approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 1d85a07 into apigee:2.x Jul 17, 2023
5 checks passed
@shishir-intelli shishir-intelli mentioned this pull request Jul 17, 2023
Merged
@shishir-intelli shishir-intelli deleted the nitpick_internal_name branch July 27, 2023 06:29
@shishir-intelli shishir-intelli mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shishir-intelli @divya-intelli