-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WePay support #65
base: master
Are you sure you want to change the base?
Conversation
What do you think if we added this as a branch? I've just implemented stripe integration, and I think it makes more sense to create three branches - master which uses amazon, a stripe branch that uses stripe and then a we pay branch that uses we pay. That way it gives the user an easy choice. Thoughts? |
Sounds great. The implementation that I made using WePay, gave the "possibility" to the user to choose either WePay or Amazon in the Settings file. That's why I put it on master. Do you want to create a branch and I push it there? |
@novito's implementation sounds better. Give the option for the user to choose whichever payment processor they'd like (via the Settings file). I'd suggest making a branch which could possibly integrate all 3 or more if you'd like. (via the settings file, ofcourse) |
I believe that an idealistic solution is give the final user the possibility to choose their payment service when doing a preorder. But that would require a "big" change. |
@novito I assumed the one using selfstarter (or implementing rather) to be the user! facepalm (damn that dev tunnel vision) But from an actual user's perspective what you suggest is pretty much the ideal solution. |
Actually my implementation considers the "user" the one using selfstarter as a gem (not the final user). But I believe an ideal solution would be the one that lets the final user to choose between a several among of payment services. |
test On Mon, Nov 25, 2013 at 8:56 AM, Joan.R [email protected] wrote:
|
Hey man, Great work you did here. I would like to share with you my pull resquest. I've extracted the payment/prefill logic to a business class. If you don't mind, you can follow the same pattern to extract all this code from controller. If you think it is not worthy, I could do it for you, I would be glad to help with. |
I have added the ability of having WePay as a payment service. It's not that the User can choose the payment service, but it's a choice of the application. I am working on letting the User who does the order to choose the payment service, and I might be pushing that later.