Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make postinstall script cross-platform (closes #225) #229

Closed
wants to merge 1 commit into from

Conversation

AroshAkalanka
Copy link

@AroshAkalanka AroshAkalanka commented Oct 16, 2024

This PR resolves the installation issue mentioned in #225.

The previous postinstall script used a bash-style command that caused errors on Windows systems. This has been replaced with a Node.js-based solution to ensure compatibility across all platforms.

Change:

  • Removed the bash-style conditional.
  • Added a new Node.js script to check for the lib directory and run the build if necessary.

Let me know if any further changes are needed. Thanks!

…ution


The previous postinstall script used a bash-style 'if' statement, causing installation failures on Windows systems. Replaced it with a Node.js-based script to ensure compatibility across all environments.
@AroshAkalanka AroshAkalanka marked this pull request as ready for review October 16, 2024 11:43
@AroshAkalanka AroshAkalanka changed the title fix: replace bash-specific postinstall script with cross-platform sol… fix: make postinstall script cross-platform (closes #225) Oct 16, 2024
@olivierapivideo
Copy link
Member

Hi @AroshAkalanka
Sorry for the inconvenience and thanks for the fix. We've integrated it in our API clients generator. The version 2.6.5 contains it.

@AroshAkalanka
Copy link
Author

Hi @olivierapivideo,
Thanks for the swift response and for integrating the fix! Glad I could help. 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants