-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audit log bugs #5006
Closed
BlackBear2003
wants to merge
4
commits into
apolloconfig:master
from
BlackBear2003:fix-audit-log-bugs
Closed
Fix audit log bugs #5006
BlackBear2003
wants to merge
4
commits into
apolloconfig:master
from
BlackBear2003:fix-audit-log-bugs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add patch of dealing with collection-type arg when AOP capturing input parameter for "AnyMatched".
Codecov Report
@@ Coverage Diff @@
## master #5006 +/- ##
============================================
+ Coverage 49.27% 49.30% +0.03%
- Complexity 1889 1893 +4
============================================
Files 372 372
Lines 11538 11544 +6
Branches 1123 1126 +3
============================================
+ Hits 5685 5692 +7
+ Misses 5513 5512 -1
Partials 340 340
|
This bug has been fixed well, could this pr be merged? |
Anilople
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added on #5008 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Fix the serious bug which I left on last PR #4985
Which issue(s) this PR fixes:
Fixes # #4985
Brief changelog
Fixed some incorrect method parameter calls, fixed some issues with the front-end interface.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.