Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit log bugs #5006

Closed

Conversation

BlackBear2003
Copy link
Member

@BlackBear2003 BlackBear2003 commented Nov 2, 2023

What's the purpose of this PR

Fix the serious bug which I left on last PR #4985

Which issue(s) this PR fixes:

Fixes # #4985

Brief changelog

Fixed some incorrect method parameter calls, fixed some issues with the front-end interface.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #5006 (776e632) into master (bc55ba6) will increase coverage by 0.03%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##             master    #5006      +/-   ##
============================================
+ Coverage     49.27%   49.30%   +0.03%     
- Complexity     1889     1893       +4     
============================================
  Files           372      372              
  Lines         11538    11544       +6     
  Branches       1123     1126       +3     
============================================
+ Hits           5685     5692       +7     
+ Misses         5513     5512       -1     
  Partials        340      340              
Files Coverage Δ
...ollo/audit/component/ApolloAuditLogApiJpaImpl.java 83.60% <33.33%> (-2.84%) ⬇️
...mework/apollo/audit/aop/ApolloAuditSpanAspect.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@nobodyiam nobodyiam requested a review from Anilople November 3, 2023 01:06
@BlackBear2003
Copy link
Member Author

This bug has been fixed well, could this pr be merged?

@Anilople

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople
Copy link
Contributor

Add some tests?

image

@BlackBear2003
Copy link
Member Author

Add some tests?

image

added on #5008

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@BlackBear2003 BlackBear2003 deleted the fix-audit-log-bugs branch November 10, 2023 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants