Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create quick-start-btpanel.md #5274

Merged
merged 48 commits into from
Nov 23, 2024
Merged

Conversation

bestlaw66
Copy link
Contributor

@bestlaw66 bestlaw66 commented Nov 6, 2024

在国内有大部分用户都在使用宝塔面板管理服务器,因此增加使用宝塔面板部署的教程,可视化的部署文档可以帮助用户更加便捷的部署apollo

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • New Features

    • Added deployment guidance for Apollo using aaPanel and BTPanel (available in English and Chinese).
    • Introduced new sidebar entries for quick access to the deployment guides.
  • Documentation

    • Detailed step-by-step instructions for deploying Apollo with Docker on aaPanel and BTPanel, including prerequisites and configuration settings.
    • Included security considerations regarding port exposure and firewall configuration in the deployment guides.

在国内有大部分用户都在使用宝塔面板管理服务器,因此增加使用宝塔面板部署的教程,可视化的部署文档可以帮助用户更加便捷的部署apollo
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 6, 2024
Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Walkthrough

The changes include the addition of new documentation entries in both English and Chinese for deploying the Apollo application using aaPanel and BTPanel, respectively. The English sidebar has been updated to link to a new guide on deploying Apollo with aaPanel, while the Chinese sidebar has been updated to link to a guide for BTPanel. Each guide provides detailed installation and configuration steps tailored to their respective environments.

Changes

File Path Change Summary
docs/en/_sidebar.md Added entry: [Quickly deploy Apollo based on the aaPanel](en/deployment/third-party-tool-btpanel.md) in the "Deployment By Third-party Tool" section.
docs/en/deployment/third-party-tool-btpanel.md Introduced deployment guidelines for Apollo using aaPanel, including installation and configuration steps.
docs/zh/_sidebar.md Added entry: [基于宝塔面板快速部署 Apollo](zh/deployment/third-party-tool-btpanel.md) in the "第三方工具部署" section.
docs/zh/deployment/third-party-tool-btpanel.md Created a new document detailing deployment steps for Apollo using BTPanel, including prerequisites and access instructions.

Poem

In the garden of code, we hop with delight,
New paths for Apollo, shining so bright.
With aaPanel and BTPanel, deployment's a breeze,
Follow the steps, and do it with ease!
So gather 'round, friends, let’s celebrate here,
For every new guide brings us all cheer! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 88b0423 and d95ed87.

⛔ Files ignored due to path filters (1)
  • docs/zh/images/deployment/btpanel/console.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • docs/zh/deployment/third-party-tool-btpanel.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/zh/deployment/third-party-tool-btpanel.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (3)
docs/zh/deployment/quick-start-btpanel.md (3)

1-3: Remove extra blank line and consider adding metadata.

The document could benefit from better formatting and consistency:

  1. Remove the extra blank line at the start
  2. Consider adding front matter metadata (like other docs) to help with documentation organization
-
-
# 宝塔面板(适用9.2.0及以上的版本)快速部署Apollo
+---
+title: 使用宝塔面板快速部署Apollo
+sidebar_label: 宝塔面板部署
+---
+
+# 宝塔面板(适用9.2.0及以上的版本)快速部署Apollo

4-6: Add system requirements and version compatibility details.

The preparation section should include:

  1. Supported operating systems
  2. Minimum system requirements (CPU, RAM, disk space)
  3. Specific BT Panel version compatibility notes

16-18: Add security considerations and detailed reverse proxy setup.

The notes section should address:

  1. Security implications of enabling external access
  2. Step-by-step reverse proxy configuration
  3. SSL/TLS setup recommendations
  4. Network security best practices
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0cba391 and 1aa2c6d.

📒 Files selected for processing (1)
  • docs/zh/deployment/quick-start-btpanel.md (1 hunks)

docs/zh/deployment/quick-start-btpanel.md Outdated Show resolved Hide resolved
docs/zh/deployment/quick-start-btpanel.md Outdated Show resolved Hide resolved
docs/zh/deployment/quick-start-btpanel.md Outdated Show resolved Hide resolved
@nobodyiam
Copy link
Member

请参考 #4283 增加 sidebar 链接以及英文说明

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
@bestlaw66
Copy link
Contributor Author

请参考 #4283 增加 sidebar 链接以及英文说明

已参考更新

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🧹 Outside diff range and nitpick comments (4)
docs/zh/deployment/third-party-tool-btpanel.md (1)

3-7: Consider adding system requirements to prerequisites.

The prerequisites section should include:

  • Minimum system requirements (CPU, RAM, disk space)
  • Supported operating systems
  • Network requirements (if any)
docs/en/deployment/third-party-tool-btpanel.md (3)

17-17: Remove redundant title

This line duplicates the title from the beginning of the document.

-aaPanel(Applicable versions 7.0.11 and above) Deployment guidelines

34-34: Improve sentence structure

The sentence structure needs improvement:

-The domain name is optional, if the domain name is filled, it can be managed through [Website]--> [Proxy Project], and you do not need to check [Allow external access] after filling in the domain name, otherwise you need to check it before you can access it through the port
+The domain name is optional. If a domain name is provided, it can be managed through [Website] --> [Proxy Project]. In this case, you do not need to check [Allow external access]. However, if no domain name is provided, you must check [Allow external access] to enable port-based access.
🧰 Tools
🪛 LanguageTool

[typographical] ~34-~34: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...nal access] after filling in the domain name, otherwise you need to check it before you can acc...

(THUS_SENTENCE)


40-46: Fix list indentation

The unordered list items should have consistent indentation. Apply the following formatting:

-- Name: application name, default `Apollo-characters`
-- Version selection: default `latest`
-- Domain name: If you need to access directly through the domain name, please configure the domain name here and resolve the domain name to the server
-- Allow external access: If you need direct access through `IP+Port`, please check. If you have set up a domain name, please do not check here.
-- Web port: Default `8070`, can be modified by yourself
-- Communication port: Default `8080`, can be modified by yourself
-- Metadata port: Default `8090`, can be modified by yourself
+- Name: application name, default `Apollo-characters`
+- Version selection: default `latest`
+- Domain name: If you need to access directly through the domain name, please configure the domain name here and resolve the domain name to the server
+- Allow external access: If you need direct access through `IP+Port`, please check. If you have set up a domain name, please do not check here.
+- Web port: Default `8070`, can be modified by yourself
+- Communication port: Default `8080`, can be modified by yourself
+- Metadata port: Default `8090`, can be modified by yourself
🧰 Tools
🪛 Markdownlint

40-40: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


41-41: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


42-42: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


43-43: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


44-44: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


45-45: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


46-46: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa2c6d and b266c4c.

📒 Files selected for processing (4)
  • docs/en/_sidebar.md (1 hunks)
  • docs/en/deployment/third-party-tool-btpanel.md (1 hunks)
  • docs/zh/_sidebar.md (1 hunks)
  • docs/zh/deployment/third-party-tool-btpanel.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/en/deployment/third-party-tool-btpanel.md

[typographical] ~34-~34: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...nal access] after filling in the domain name, otherwise you need to check it before you can acc...

(THUS_SENTENCE)

🪛 Markdownlint
docs/en/deployment/third-party-tool-btpanel.md

40-40: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


41-41: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


42-42: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


43-43: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


44-44: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


45-45: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


46-46: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


3-3: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

🔇 Additional comments (2)
docs/zh/_sidebar.md (1)

16-16: LGTM! The sidebar entry is well-structured.

The new entry for BTPanel deployment is correctly placed under the third-party tools section and follows the existing documentation pattern.

Let's verify the existence of both Chinese and English documentation files:

✅ Verification successful

✅ Documentation files exist for both languages as expected

The verification confirms that both the Chinese and English documentation files exist at their expected locations:

  • docs/zh/deployment/third-party-tool-btpanel.md
  • docs/en/deployment/third-party-tool-btpanel.md
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of both Chinese and English documentation files
# Expected: Both files should exist as mentioned in the AI summary

echo "Checking for Chinese documentation file..."
fd "third-party-tool-btpanel.md" docs/zh/deployment/

echo "Checking for English documentation file..."
fd "third-party-tool-btpanel.md" docs/en/deployment/

Length of output: 389

docs/en/_sidebar.md (1)

16-16: Clarify panel naming and verify documentation path.

There are inconsistencies in the naming of the panel:

  • PR title and description mention "BTPanel" and "Baota panel"
  • The sidebar entry refers to "aaPanel"
  • The documentation path contains "btpanel"

Please clarify if these refer to the same panel and ensure consistent naming across documentation.

Let's verify the existence of the referenced documentation file:

✅ Verification successful

Naming is consistent across documentation

The naming is actually consistent across the documentation:

  • English version correctly uses "aaPanel" throughout (international branding)
  • Chinese version uses "宝塔面板" (Baota Panel - local branding)
  • Both refer to the same product, as evidenced by the similar content structure and official website links
  • The file path using "btpanel" is just a technical identifier and doesn't affect user-facing content

The documentation exists and maintains proper localization conventions for both markets.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the referenced documentation file exists
# Expected: File should exist at the specified path

# Test 1: Check if the documentation file exists
if [ -f "docs/en/deployment/third-party-tool-btpanel.md" ]; then
    echo "Documentation file exists"
else
    echo "Warning: Documentation file not found"
fi

# Test 2: Search for any files containing btpanel or aapanel
fd -i "btpanel|aapanel" docs/

Length of output: 246


Script:

#!/bin/bash
# Let's check the content of both files to understand the naming consistency
echo "=== English Version ==="
head -n 10 docs/en/deployment/third-party-tool-btpanel.md

echo -e "\n=== Chinese Version ==="
head -n 10 docs/zh/deployment/third-party-tool-btpanel.md

# Search for panel naming references in both files
echo -e "\n=== Panel Name References ==="
rg -i "panel|宝塔|aaPanel|btpanel|baota" docs/en/deployment/third-party-tool-btpanel.md docs/zh/deployment/third-party-tool-btpanel.md

Length of output: 2672

docs/zh/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/zh/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/zh/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/zh/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
@bestlaw66
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)
docs/en/deployment/third-party-tool-btpanel.md (2)

3-4: Improve content organization

The installation instruction is duplicated in the prerequisites section. Consider removing it here and keeping it only in the prerequisites section for better content organization.

-  Go to [aaPanel official website](https://www.aapanel.com/new/download.html), Select the script to download and install
-  (Skip this step if you already have it installed)

44-44: Add verification steps for successful initialization

The initialization step should include how to verify successful completion:

  1. What logs to check
  2. What indicators show successful initialization
  3. How to troubleshoot common issues

Add verification steps:

 6. After submission, the panel will automatically initialize the application, which will take about `1-3` minutes. It can be accessed after the initialization is completed.
+
+   To verify successful initialization:
+   - Check the Docker container status in aaPanel
+   - Verify all services are running: `apollo-configservice`, `apollo-adminservice`, and `apollo-portal`
+   - Check container logs for any error messages
+
+   Common issues:
+   - If initialization takes longer than 3 minutes, check the container logs
+   - If any service fails to start, ensure all ports are available
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 552aa79 and 36f5c9a.

📒 Files selected for processing (2)
  • docs/en/deployment/third-party-tool-btpanel.md (1 hunks)
  • docs/zh/deployment/third-party-tool-btpanel.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/zh/deployment/third-party-tool-btpanel.md
🧰 Additional context used
🪛 Markdownlint
docs/en/deployment/third-party-tool-btpanel.md

1-1: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 36f5c9a and cec7ae0.

📒 Files selected for processing (2)
  • docs/en/deployment/third-party-tool-btpanel.md (1 hunks)
  • docs/zh/deployment/third-party-tool-btpanel.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/zh/deployment/third-party-tool-btpanel.md
🧰 Additional context used
🪛 Markdownlint
docs/en/deployment/third-party-tool-btpanel.md

1-1: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

🔇 Additional comments (1)
docs/en/deployment/third-party-tool-btpanel.md (1)

52-70: LGTM! Well-documented access methods

The access methods section is comprehensive and includes:

  • Clear instructions for both domain and IP-based access
  • HTTPS configuration steps
  • Security considerations

docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
docs/en/deployment/third-party-tool-btpanel.md Outdated Show resolved Hide resolved
@bestlaw66
Copy link
Contributor Author

image
image
I can now confirm that the image can be displayed normally.

@nobodyiam
Copy link
Member

I believe you can do better.

image

@bestlaw66
Copy link
Contributor Author

I believe you can do better.

image

Sorry, I overlooked this point, but now I have corrected it.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@nobodyiam nobodyiam merged commit add5715 into apolloconfig:master Nov 23, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants