docs(charts): 更新 Helm chart 包和索引 #5310
Conversation
dosubot
bot
added
the
size:L
WalkthroughThis pull request updates the Apollo Configuration Center's distributed deployment guide for both English and Chinese documentation. The changes introduce new configuration options for Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/charts/index.yaml (1)
Line range hint
916-916: New service annotation support addedAdded new configuration options for service annotations:
- configService.service.annotations: Allows customizing annotations for apollo-configservice
- adminService.service.annotations: Allows customizing annotations for apollo-adminservice
This enhancement provides more flexibility in Kubernetes service configuration.
Consider documenting common annotation use cases and examples in the deployment guide.
Also applies to: 947-947
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/charts/index.yaml(17 hunks)docs/en/deployment/distributed-deployment-guide.md(3 hunks)docs/zh/deployment/distributed-deployment-guide.md(3 hunks)
🔇 Additional comments (3)
docs/charts/index.yaml (1)
5-19: Version upgrade to 2.3.0 with improved configuration capabilitiesThe chart has been upgraded from 1.9.1 to 2.3.0 with the following notable changes:
- Updated repository URLs from ctripcorp to apolloconfig
- Added support for service annotations
- Updated timestamps to reflect recent changes
docs/zh/deployment/distributed-deployment-guide.md (1)
916-916: LGTM! Documentation for new Kubernetes service annotations.The addition of
configService.service.annotationsandadminService.service.annotationsconfiguration options is well documented and properly integrated into the Helm chart configuration section.Also applies to: 947-947
docs/en/deployment/distributed-deployment-guide.md (1)
966-966: LGTM! Documentation for new Kubernetes service annotations.The addition of
configService.service.annotationsandadminService.service.annotationsconfiguration options is well documented and properly integrated into the Helm chart configuration section. The English translation matches the Chinese version.Also applies to: 997-997
lambda-hj
force-pushed
the
update_charts
branch
from
8af017c to
bc00ada
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
The root of |
…tal 的服务添加注解配置 - 在 apollo-configservice、apollo-adminservice 和 apollo-portal 的服务配置中添加了 annotations 参数 - 新增的注解配置项适用于图表版本 0.9.0 及以上 - 更新了英文和中文的分布式部署指南文档，添加了新的配置项说明
lambda-hj
force-pushed
the
update_charts
branch
from
684ac6e to
1531062
Compare
dosubot
bot
added
size:XS
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/en/deployment/distributed-deployment-guide.md (1)
Line range hint
966-1157: Documentation structure and clarityThe documentation clearly explains the new configuration options with:
- Proper formatting and indentation
- Consistent style with existing documentation
- Clear examples and default values
Consider adding example annotations to demonstrate common use cases, such as:
configService: service: annotations: prometheus.io/scrape: "true" prometheus.io/port: "8080"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/deployment/distributed-deployment-guide.md(3 hunks)docs/zh/deployment/distributed-deployment-guide.md(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/zh/deployment/distributed-deployment-guide.md
🔇 Additional comments (3)
docs/en/deployment/distributed-deployment-guide.md (3)
966-966: New configuration option added for configService service annotationsThe addition of
configService.service.annotationsconfiguration allows users to specify custom annotations for the apollo-configservice Kubernetes service, enhancing service management capabilities.
997-997: New configuration option added for adminService service annotationsThe addition of
adminService.service.annotationsconfiguration allows users to specify custom annotations for the apollo-adminservice Kubernetes service, enhancing service management capabilities.
1157-1157: New configuration option added for portal service annotationsThe addition of
service.annotationsconfiguration allows users to specify custom annotations for the apollo-portal Kubernetes service, enhancing service management capabilities.
What's the purpose of this PR
update helm charts and notes on annotations in the docs
Which issue(s) this PR fixes:
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
apollo-configserviceandapollo-adminservice