-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use WeakCache
for executeSelectionSet
et al wrappers
#12361
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0f0ccdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 804167341da3abcb5766f5d3 |
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
This would address #12360 and ensure that
optimism
-wrapped caclulations that can't possibly be re-executed because the arguments have left memory are cache-collected.That said, I am pretty sure that I excluded these three methods intentionally while doing my cache collection analysis (internal link). I've reread my documentation from back then and don't really find a reason why I did that, but we should probably discuss this more before merging this.