-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Defer metadata extensions #581
fix: Defer metadata extensions #581
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ef6b2e08b931f268a3cf7ce0 |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Only thing I'm not clear on is whether the |
We should probably also get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
e4f12df6 fix: Defer metadata extensions (#581) git-subtree-dir: apollo-ios-codegen git-subtree-split: e4f12df6f713fd15c19e734c9c6300fb0c1e4db5
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 7d863f5 git-subtree-split: e4f12df6f713fd15c19e734c9c6300fb0c1e4db5
Fixes apollographql/apollo-ios#3503
This implements solution 2 in the issue description for the following reasons:
MARK
comment line.