chore: change devtools dependency & move it to dev dependencies #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the previously-used
electron-devtools-installerrecently got an update after 3 years. Since it is maintained by Electron maintainers, it seems better in the long run to switch back to it.Also, since its README suggested installing it as a dev dependency, I checked the app functionality in dev and preview builds, and it worked fine.
Finally, the
allowFileAccess: trueoption was removed, since Electron'sloadFile()method is not used in dev mode, which is the only scope of relevance for this package. Extensions were confirmed to still load fine.