Skip to content

Commit

Permalink
Merge pull request #1525 from appknox/PD-1669-Fix-Notification-Store-…
Browse files Browse the repository at this point in the history
…Link

Fix: Redirecting to Store Link from Notification
  • Loading branch information
future-pirate-king authored Jan 28, 2025
2 parents 7bf922d + 021d32f commit be08f2f
Show file tree
Hide file tree
Showing 9 changed files with 36 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@
</AkTypography>

<div data-test-nf-str-url-upldfailnprjdeny1-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,17 @@
{{#if @context.store_url}}
<span local-class='pipe'>|</span>

<AkLink
<AkButton
data-test-nf-str-url-upldfailnprjdeny2-viewAppOnStorelink
@tag='a'
@variant='text'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
{{/if}}
</AkStack>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@
</AkTypography>

<div data-test-nf-str-url-upldfailnscreatd1-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@
</AkTypography>

<div data-test-nf-str-url-upldfailnsunaprv1-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@
</AkTypography>

<div data-test-nf-str-url-upldfailpay2-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@
</AkTypography>

<div data-test-nf-str-url-upldfailpayrq1-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,16 @@
</AkTypography>

<div data-test-nf-str-url-upload-success-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@
</div>

<div data-test-nf-str-url-vldtn-err-link>
<AkLink
<AkButton
@tag='a'
@variant='text'
@color='primary'
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
</div>
</AkStack>
7 changes: 4 additions & 3 deletions app/components/notifications-page/namespace-message/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,18 @@
{{/if}}

{{#if @context.store_url}}
<AkLink
<AkButton
data-test-namespaceMessage-viewAppOnStorelink
@tag='a'
@variant='text'
@color={{unless this.isUnModerated 'primary'}}
@underline='always'
target='_blank'
href={{@context.store_url}}
rel='noopener noreferrer'
@title={{t 'notificationModule.viewAppOnStore'}}
>
{{t 'notificationModule.viewAppOnStore'}}
</AkLink>
</AkButton>
{{/if}}
</AkStack>
{{/if}}
Expand Down

0 comments on commit be08f2f

Please sign in to comment.