Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routes migration js to ts #1309

Merged
merged 1 commit into from
Jan 5, 2024
Merged

routes migration js to ts #1309

merged 1 commit into from
Jan 5, 2024

Conversation

future-pirate-king
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 21, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b72e10c
Status: ✅  Deploy successful!
Preview URL: https://66a87353.irenestaging.pages.dev
Branch Preview URL: https://pd-992-conversion-of-routes.irenestaging.pages.dev

View logs

@future-pirate-king future-pirate-king force-pushed the PD-992-Conversion-of-Routes-files-to-typescript branch from 6b22ada to 6768df8 Compare December 28, 2023 09:49
@future-pirate-king future-pirate-king force-pushed the PD-992-Conversion-of-Routes-files-to-typescript branch from 6768df8 to dbf09de Compare January 3, 2024 05:27
@future-pirate-king future-pirate-king force-pushed the PD-992-Conversion-of-Routes-files-to-typescript branch from dbf09de to 898fc32 Compare January 3, 2024 05:44
@future-pirate-king future-pirate-king marked this pull request as ready for review January 3, 2024 05:58
Yibaebi
Yibaebi requested changes Jan 5, 2024
View reviewed changes
app/services/partner.ts Outdated Show resolved Hide resolved
@future-pirate-king future-pirate-king force-pushed the PD-992-Conversion-of-Routes-files-to-typescript branch from 898fc32 to b72e10c Compare January 5, 2024 12:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@future-pirate-king future-pirate-king merged commit f53a7eb into develop Jan 5, 2024
5 checks passed
@future-pirate-king future-pirate-king deleted the PD-992-Conversion-of-Routes-files-to-typescript branch January 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yibaebi Yibaebi Yibaebi approved these changes

@Praseetha-KR Praseetha-KR Awaiting requested review from Praseetha-KR

@cosmosgenius cosmosgenius Awaiting requested review from cosmosgenius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@future-pirate-king @Yibaebi