CI: concurrency=complete require-explicit-sendable #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
adopt_strict_concurrency
branch
from
a754d2e to
726c54c
Compare
Lukasa
reviewed
Oct 15, 2024
| @@ -17,7 +17,8 @@ import PackageDescription | |||
| import class Foundation.ProcessInfo | |||
|
|
|||
| let upcomingFeatureSwiftSettings: [SwiftSetting] = [ | |||
| .enableUpcomingFeature("ExistentialAny") | |||
| .enableUpcomingFeature("ExistentialAny"), | |||
| .enableUpcomingFeature("StrictConcurrency"), | |||
There was a problem hiding this comment.
We probably don't want this unilaterally: either only in CI, or only in the Swift 6 compiler.
There was a problem hiding this comment.
Oh nevermind, for ASN.1 it's totally fine as it doesn't have any concurrency anyway.
FranzBusch
reviewed
Oct 15, 2024
.github/workflows/pull_request.yml
Outdated
Comment on lines
19
to
21
| linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" |
There was a problem hiding this comment.
We are enabling strict concurrency in the Package.swift already so we don't have to pass it here as well.
.github/workflows/scheduled.yml
Outdated
Comment on lines
15
to
17
| linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable" |
Motivation: Adopt `-Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendable` in CI to lock-in concurrency-safety wins. Modifications: Added strict flags to pull request and scheduled GHA CI on Swift 6.0. Result: CI should ensure we don't regress data-race safety on Swift 6.0.
rnro
force-pushed
the
adopt_strict_concurrency
branch
from
a70a865 to
7202800
Compare
rnro
force-pushed
the
adopt_strict_concurrency
branch
from
7202800 to
489a0fe
Compare
FranzBusch
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Adopt
-Xswiftc -strict-concurrency=complete -Xswiftc -require-explicit-sendablein CI to lock-in concurrency-safety wins.Modifications:
Added strict flags to pull request and scheduled GHA CI on Swift 6.0. Add
StrictConcurrencytoPackage.swift.Result:
CI should ensure we don't regress data-race safety on Swift 6.0.