-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferred algorithm #222
Open
tcldr
wants to merge
6
commits into
apple:main
Choose a base branch
from
tcldr:pr/deferred
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deferred algorithm #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fantastic! I think this is perhaps one of the first few we should run as soon as we hit 1.0. |
phausler
reviewed
Oct 20, 2022
phausler
reviewed
Oct 20, 2022
Great – thanks for the feedback! Should be incorporated now. |
FranzBusch
reviewed
Oct 24, 2022
FranzBusch
reviewed
Oct 24, 2022
Co-authored-by: Franz Busch <[email protected]>
Co-authored-by: Franz Busch <[email protected]>
Co-authored-by: Franz Busch <[email protected]>
@FranzBusch yes, much clearer. Thanks! |
Keithbreadley
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferred
Proposal: NNNN
Authors: Tristan Celder
Review Manager: TBD
Status: Awaiting feedback
Implementation: [Source |
Tests]
Decision Notes: Additional Commentary
Bugs:
Introduction
AsyncDeferredSequence
provides a convenient way to postpone the initialization of a sequence to the point where it is requested by a sequence consumer.Motivation
Some source sequences may perform expensive work on initialization. This could be network activity, sensor activity, or anything else that consumes system resources. While this can be mitigated in some simple situtations by only passing around a sequence at the point of use, often it is favorable to be able to pass a sequence to its eventual point of use without commencing its initialization process. This is especially true for sequences which are intended for multicast/broadcast for which a reliable startup and shutdown procedure is essential.
A simple example of a seqeunce which may benefit from being deferred is provided in the documentation for AsyncStream:
In the supplied code sample, the closure provided to the AsyncStream initializer will be executed immediately upon initialization;
QuakeMonitor.startMonitoring()
will be called, and the stream will then begin buffering its contents waiting to be iterated. Whilst this behavior is sometimes desirable, on other occasions it can cause system resources to be consumed unnecessarily.Proposed solution
AsyncDeferredSequence
provides a way to postpone the initialization of an an arbitrary async sequence until the point of use:Now, potentially expensive system resources are consumed only at the point they're needed.
Detailed design
AsyncDeferredSequence
is a trivial algorithm supported by some convenience functions.Functions
The synchronous function can be auto-escaped, simplifying the call-site. While the async variant allows a sequence to be initialized within a concurrency context other than that of the end consumer.
Naming
The
deferred(_:)
function takes its inspiration from the Combine publisher of the same name with similar functionality. However,lazy(_:)
could be quite fitting, too.Comparison with other libraries
ReactiveX ReactiveX has an API definition of Defer as a top level operator for generating observables.
Combine Combine has an API definition of Deferred as a top-level convenience publisher.
Effect on API resilience
Deferred has a trivial implementation and is marked as
@frozen
and@inlinable
. This removes the ability of this type and functions to be ABI resilient boundaries at the benefit of being highly optimizable.Alternatives considered