Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adopt GitHub actions #193

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[CI] Adopt GitHub actions #193

merged 1 commit into from
Oct 21, 2024

Conversation

FranzBusch
Copy link
Member

No description provided.

@FranzBusch FranzBusch added the semver/none No version bump required. label Sep 6, 2024
@FranzBusch FranzBusch force-pushed the fb-gha-ci branch 2 times, most recently from 871933b to 7d2e188 Compare September 6, 2024 14:17
@FranzBusch FranzBusch force-pushed the fb-gha-ci branch 2 times, most recently from 29d6d51 to 172717c Compare September 16, 2024 14:04
@FranzBusch
Copy link
Member Author

@Lukasa @dnadoba any idea why the benchmarks regressed on the nightlies here?

@Lukasa
Copy link
Contributor

Lukasa commented Sep 18, 2024

I'm afraid I don't. It'd be good if someone could find the time to investigate that.

@FranzBusch FranzBusch force-pushed the fb-gha-ci branch 2 times, most recently from 7b86385 to d720055 Compare October 18, 2024 09:22
Copy link
Member Author

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready for review now @Lukasa. Some of the benchmarks regressed quite a lot on Swift 6 and I will investigate that in a follow up but I want to unblock the CI transition now. If the changes look good to you then please go ahead and disable the old CI and add the new checks as branch protection.

@FranzBusch FranzBusch requested a review from Lukasa October 18, 2024 09:37
@Lukasa Lukasa merged commit c0b6a47 into main Oct 21, 2024
30 of 36 checks passed
@Lukasa Lukasa deleted the fb-gha-ci branch October 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants