[BigInt tests][No merge] ❌🐰 Apple #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the #242 Using tests from “Violet - Python VM written in Swift” before.
=== DO NOT MERGE! Discussion only. ===
🐰 Discussion
Tests copied and adapted from: github.com/apple/swift/test/Prototypes/BigInt.swift.
This is more of a "Is there anything interesting in there?", rather than "Let's use those tests.". If you see something, then we may want to move it to appropriate location.
Not sure about license… technically this is
github.com/apple/swift, so who cares… but somebody may want to look into this.❌ Failures
Div, xor and magnitude.
Nothing interesting, they were described in other PRs.