Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idiomatic naming strategy as opt-in #679

Merged
merged 39 commits into from
Dec 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
140f5c0
[Experiment] Optimistic naming strategy as opt-in
czechboy0 Nov 13, 2024
24a97e6
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Nov 22, 2024
d9b901e
Remove unneeded code
czechboy0 Nov 22, 2024
3ded3fe
Updated draft proposal
czechboy0 Nov 22, 2024
4303842
Update SOAR-0013.md
czechboy0 Nov 25, 2024
6c0f05c
PR feedback
czechboy0 Nov 26, 2024
33ef5ea
Merge branch 'hd-naming-strategy-optimistic' of github.com:czechboy0/…
czechboy0 Nov 26, 2024
d6c037c
Proposal updates
simonjbeaumont Nov 27, 2024
8f51c49
Remove proposal, broken out into #683
czechboy0 Nov 27, 2024
7cbca17
Update Petstore fixtures to use idiomatic naming
czechboy0 Nov 27, 2024
cdcaed7
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Nov 27, 2024
c41d3de
Updated Petstore tests
czechboy0 Nov 27, 2024
bda0eb3
Updating tests
czechboy0 Nov 27, 2024
14b090a
Update the implementation with the latest feedback on the proposal
czechboy0 Nov 28, 2024
013f463
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Dec 2, 2024
acb471e
Add test cases for acronyms
czechboy0 Dec 2, 2024
4bd4904
PR feedback
czechboy0 Dec 10, 2024
94173c7
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Dec 10, 2024
6d98aa4
Clarify SwiftNameOptions
czechboy0 Dec 10, 2024
fa1b0fa
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Dec 11, 2024
a098cd1
Update docs
czechboy0 Dec 11, 2024
fd62811
Bump the runtime version in test
czechboy0 Dec 11, 2024
d5ace32
Merge branch 'main' into hd-naming-strategy-optimistic
czechboy0 Dec 16, 2024
21e5f05
Reformatted
czechboy0 Dec 16, 2024
3da75b8
Apply suggestions from code review
czechboy0 Dec 16, 2024
cda4a4c
Additional test cases
czechboy0 Dec 16, 2024
69de944
Some PR feedback, some temporary updates to snippet reference tests (…
czechboy0 Dec 16, 2024
dbcd035
Remove SwiftNameOptions.Capitalization
czechboy0 Dec 16, 2024
8567ad3
Undo changes to tutorial Package.swift
czechboy0 Dec 16, 2024
96f90be
Undo changes to the filter command
czechboy0 Dec 16, 2024
bd28e53
Added + as a word separator
czechboy0 Dec 16, 2024
4cb7b14
Revert snippet tests changes, add only specific new tests
czechboy0 Dec 17, 2024
837e6ed
Formatting
czechboy0 Dec 17, 2024
af9b5ff
Update test now that we also handle plus signs in the idiomatic strategy
czechboy0 Dec 17, 2024
9c9f657
Always run the string through the defensive strategy after finishing …
czechboy0 Dec 17, 2024
4d4e9b6
Test fixes
czechboy0 Dec 17, 2024
603970c
Start of refactor of SafeNameGenerator
czechboy0 Dec 18, 2024
762925d
Finished refactoring
czechboy0 Dec 18, 2024
6763372
Merge branch 'main' into hd-naming-strategy-optimistic
simonjbeaumont Dec 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Undo changes to the filter command
czechboy0 committed Dec 16, 2024
commit 96f90be0aa096af9587f0aefa7ed107f64a194bd
2 changes: 1 addition & 1 deletion Sources/swift-openapi-generator/FilterCommand.swift
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ private func timing<Output>(_ title: String, _ operation: @autoclosure () throws
}

private let sampleConfig = _UserConfig(
generate: [.types, .client],
generate: [],
filter: DocumentFilter(
operations: ["getGreeting"],
tags: ["greetings"],