Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a initializer to Google_Protobuf_Duration with rounding control. #1747

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add a initializer to Google_Protobuf_Duration with rounding control. #1747

merged 2 commits into from
Jan 23, 2025

Conversation

thomasvl
Copy link
Collaborator

Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths.

@thomasvl
Add a initializer to Google_Protobuf_Duration with rounding control.
bada726 
Provide a new initializer with explicit rounding controls and map the
other initializer though the single code paths.
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 16, 2025 •
edited
Loading

There's a question to if we should deprecate the existing apis in favor of this this new one. Thoughts?

@allevato
Copy link
Collaborator

IMO, I would deprecate init(timeInterval: TimeInterval) and point users to the new one with renamed:, since the argument label in the new one more clearly spells out the behavior of the conversion.

@thomasvl
Deprecate init(timeInterval:) pointing at new api.
4ac640a 
Also remove the tests so we can still build/test warnings free and with warnings
upgraded to errors.
@thomasvl
Copy link
Collaborator Author

IMO, I would deprecate init(timeInterval: TimeInterval) and point users to the new one with renamed:, since the argument label in the new one more clearly spells out the behavior of the conversion.

Pushed a second commit with that, I can also drop it and force push again if we don't want to do it.

@thomasvl thomasvl merged commit 035c0c4 into apple:main Jan 23, 2025
12 checks passed
@thomasvl thomasvl deleted the better_interval_rounding_api branch January 23, 2025 14:11
@thomasvl thomasvl added the 🆕 semver/minor Adds new public API. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@allevato allevato allevato approved these changes

@Lukasa Lukasa Awaiting requested review from Lukasa

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasvl @allevato @tbkka