-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sun position algorithm #2870
base: master
Are you sure you want to change the base?
Sun position algorithm #2870
Conversation
9701d54
to
7daae39
Compare
8414922
to
ad8b591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very partial and superficial first review!
src/appleseed/renderer/modeling/environmentedf/hosekenvironmentedf.cpp
Outdated
Show resolved
Hide resolved
ad8b591
to
1aaa93c
Compare
Hi, @LZaw and I had another look at this PR. We feel that a few things need to be done in order for it to be merged. In particular, the Here is what we suggest:
Essentially turns the class into a very plain C++ one, and expose it to Python like you're doing now. |
Draft of sun position implementation.