Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ebola dataset from intro course. #20

Closed
wants to merge 1 commit into from
Closed

Conversation

jarvisc1
Copy link

@jarvisc1 jarvisc1 commented Nov 5, 2024

No description provided.

@jarvisc1 jarvisc1 requested a review from aspina7 November 5, 2024 07:45
@jarvisc1
Copy link
Author

jarvisc1 commented Nov 5, 2024

No rush on this, was just seeing how it works. Good instructions!

If you're happy then I can start to port the Shiny course data over to this.

I think some wrapper functions could be useful to allow the user to run

get_course_data("shiny") and then get_data is is used multiple times. I see you have a group identifier but this is within and across groups.

@aspina7
Copy link
Contributor

aspina7 commented Nov 5, 2024

Hold up lets not merge this yet. We should move the handbook data first and then if the course dataset is substantially different it becomes t1v2 - and we should be able to trace how the changes were made then.
Re courses no need to add a wrapper (get_data already able to handle multiple files) - would just need to update as described in #3.
users would then run e.g. get_data(usage = "shiny")

#' alongside \link{mpox_aggregate_table} (cumulative case totals by date and country).
#'
#'
#' @source Fictional data provided by Applied Epi for training purposes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original is from the {outbreaks} package and was edited, so would need to be acknowledged here.

@aspina7 aspina7 closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants