- B fixed issue with opening multiple files of Linux

fixes #429
approvals · Nov 6, 2023 · e649445 · e649445
1 parent 68eb07a
commit e649445
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/approvaltests-util/src/main/java/com/spun/util/tests/LinuxOpener.java b/approvaltests-util/src/main/java/com/spun/util/tests/LinuxOpener.java
@@ -23,8 +23,8 @@ public static String which(String command)
     {
       String command1 = "which " + command;
       Process p = Runtime.getRuntime().exec(command1);
-      String output = FileUtils.readStream(p.getInputStream()).trim();
       p.waitFor();
+      String output = FileUtils.readStream(p.getInputStream()).trim();
       int exitValue = p.exitValue();
       return exitValue == 0 ? output : null;
     }

diff --git a/approvaltests-util/src/test/java/com/spun/util/tests/LinuxOpenerTest.java b/approvaltests-util/src/test/java/com/spun/util/tests/LinuxOpenerTest.java
@@ -0,0 +1,30 @@
+package com.spun.util.tests;
+
+import com.spun.util.io.FileUtils;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class LinuxOpenerTest
+{
+  @Disabled("This test takes a lot of time to run and opens a browser window")
+  @Test
+  void testMultipleFilesOnLinux() throws Exception
+  {
+    File tempFile = File.createTempFile("test", ".html");
+    FileUtils.writeFile(tempFile, "<html><body><h1>Applesauce</h1></body></html>");
+    int countCorrect = 0;
+    int totalRuns = 10;
+    for (int i = 0; i < totalRuns; i++)
+    {
+      if (LinuxOpener.executeOnLinux(tempFile.getAbsolutePath(), "open"))
+      {
+        countCorrect++;
+      }
+    }
+    assertEquals(totalRuns, countCorrect);
+  }
+}