fix: State inspector shows canvas widgets #39023
Conversation
WalkthroughThe changes update the way UI widgets are filtered in the selector. An existing import for a widget name constant was removed and replaced with an import of a widget factory. A constant ( Changes
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
Bug
|
🔴🔴🔴 Cyclic Dependency Check: This PR has increased the number of cyclic dependencies by 1, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
|
🔴🔴🔴 Cyclic Dependency Check: This PR has increased the number of cyclic dependencies by 1, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
|
🔴🔴🔴 Cyclic Dependency Check: This PR has increased the number of cyclic dependencies by 1, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/src/sagas/ErrorSagas.tsx (1)
282-291: Consider adding documentation for Cypress debug handling.The special handling of empty error messages in Cypress tests would benefit from a brief comment explaining why this is necessary.
+ // Special handling for Cypress tests: Empty error messages trigger a safe crash + // to help debug test failures if ("Cypress" in window) {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/src/actions/errorActions.ts(1 hunks)app/client/src/sagas/ErrorSagas.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-build / client-build
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-lint / client-lint
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (3)
app/client/src/actions/errorActions.ts (1)
13-17: Well-structured error payload interface!The
ErrorPayloadTypeinterface provides a clear contract for error handling with appropriate optional fields.app/client/src/sagas/ErrorSagas.tsx (2)
5-24: LGTM! Well-organized imports.Imports are now logically grouped and organized, improving code readability.
352-358: Good security consideration for anonymous users!The code properly handles anonymous users by redirecting them to the login page when they encounter a PAGE_NOT_FOUND error, preventing potential information leakage.
Description
Filter out the canvas widgets from the ui segment list
Fixes #38876
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Warning
Tests have not run on the HEAD b3a7302 yet
Thu, 06 Feb 2025 05:10:14 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Refactor