Fix: add customAttributes to edit account request #13
Conversation
|
I have tested this PR, works as expected -> should be merged |
# Conflicts: # lib/src/admin.dart # lib/src/app.dart # lib/src/app/app.dart # lib/src/app/app_extension.dart # lib/src/auth.dart # lib/src/auth/auth_api_request.dart # lib/src/auth/credential.dart # lib/src/auth/token_verifier.dart # lib/src/auth/user_record.dart # lib/src/credential.dart # lib/src/database.dart # lib/src/storage.dart # lib/src/utils/error.dart # lib/src/utils/validator.dart # pubspec.yaml # test/app_test.dart # test/auth_test.dart # test/firebase_admin_test.dart # test/resources/mocks.dart # test/storage_test.dart
|
Just spent hours trying to figure out why this isn't working. Any reason why this hasn't been merged yet? |
|
Please merge with master :) |
|
What is going on? |
|
I think maybe this hasn't been merged because there's a lot of other changes in this PR. And there's this entire other method added as well: https://github.com/appsup-dart/firebase_admin/pull/13/files#diff-0b1edb4d91ddbe43e7a03462af85a8b215c06e6a3b988f8fd2a17f7b7e27690aR38 So perhaps to aid in this being merged in, this PR could be split up into three parts:
|
|
I think this just isn't maintained anymore. There was no activity by the owner for a long time on any issue or pr. I have forked this for my own use a while ago, you can use this if you want, but I'm not actively working on it: https://github.com/schultek/firebase_admin |
|
Two years later and still broken. |
The
customAttributesfield is not encoded in the final request object, therefore when callingsetCustomUserClaimsthe claims are never updated.