Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-152] Mega-linter removal. #185

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Dec 10, 2023

Pull-Request

Description

Why?

We have noticed for some time that the MegaLinter is more of a hindrance than a help. There was a situation where it reported an error when the error was not there. (here)

What?

Remove MegaLinter from project.

Links to related issues

Demo

No mega-linter :) linter

How to test

You can create example PR and check if MegaLinter exists.

Documentation

Checklist

- [ ] Functionality is covered by unit tests
- [ ] Functionality is covered by integration tests

  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika marked this pull request as ready for review December 10, 2023 17:05
Copy link
Member

@jacek-marchwicki jacek-marchwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's fine for now. We can revisit this decision later

@nowakweronika nowakweronika merged commit c6ef94d into develop Dec 11, 2023
9 of 10 checks passed
@nowakweronika nowakweronika deleted the chore/megalinter_removal branch January 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants