Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ability to filter by Service in App or Database activity pages #1038

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

@joshuaj194
Copy link
Member

This fixed the Activity tab within Apps but not within Environments where it still shows 0 operations when filtering for App and Scale:

image

@joshuaj194
Copy link
Member

works as expected in App Activity

image

Copy link
Member

@joshuaj194 joshuaj194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and screenshots above

@neurosnap
Copy link
Member Author

neurosnap commented Feb 3, 2025

This fixed the Activity tab within Apps but not within Environments where it still shows 0 operations when filtering for App and Scale

So this has not been baked into the API and I'm not fully convinced we want this behavior. We can create a separate shortcut story for that issue specifically since it will involve more work to coordinate BE changes.

My gut is telling me we should merge/deploy as-is and then have a separate shortcut story to tackle filtering by App->Scale in the Environment page. Thoughts?

https://app.shortcut.com/aptible/story/30905

@joshuaj194
Copy link
Member

That works for me. Having it in the App Activity tab is the more important change because I expect that to be used more.

@neurosnap neurosnap merged commit 11d7e30 into main Feb 3, 2025
6 checks passed
@neurosnap neurosnap deleted the fix-filter-by-child-service branch February 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants