bump the oauth2 gem #76
Conversation
| @@ -21,9 +21,10 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.add_dependency 'aptible-resource', '~> 1.0' | |||
| spec.add_dependency 'concurrent-ruby', '1.3.4' | |||
There was a problem hiding this comment.
| @@ -15,7 +15,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| RUBY_VERSION: [2.2, 2.3, 2.5, 2.6] | |||
| RUBY_VERSION: [2.6, 2.7] | |||
There was a problem hiding this comment.
I wanted to add 3.x since that's what our APIs are on, but that breaks rubocop, and I don't really want to deal with that when all I'm trying to do is make what should be a minor version bump
|
@mdelaossa I'm assigning you as reviewer because you skipped doing this previously, and the why has mostly been lost to the ether as far as I can tell. I want this for deploy-api, where it appears tests are all passing. Stupidly, I'm doing this because I want to upgrade faraday in deploy-api, and there's like 5 more blockers between me and doing that, so if there's a reason I shouldn't be doing this, it would be very easy to convince me not to. |
There was a problem hiding this comment.
I think the main reason for not updating was that things were becoming complicated back then and touching yet another repo was complicating things even more. I don't think I had an actual problem with oauth2 - I just quickly realized I didn't have to, so didn't do it
This looks good though!
No description provided.