feat: added maintenance deadline to CLI in printouts #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuravius
commented
Aug 17, 2023
madhuravius
commented
Aug 17, 2023
|
This pull request has been linked to Shortcut Story #16658: Show scheduled maintenance in the CLI. |
The JSON output will include a |
|
Currently look like this @UserNotFound 
[aptible-cli] aptible maintenance:dbs 20:19:43 git:(MR-sc-11658*) ⚡ ✭
=== test-django
couchdb between 2023-08-18 17:32:46 UTC and 2023-08-19 17:32:46 UTC
You may restart these database(s) at any time, or Aptible will restart it during the defined window.
[aptible-cli] aptible maintenance:apps 20:19:50 git:(MR-sc-11658*) ⚡ ✭
No apps found affected by maintenance schedules.We can stick it in --requiring-maintenance, but we agreed verbally previously flag was not necessary and it could live as a separate command (much like it lives as different API resources), advise if this is not desired |
|
With respect to JSON output, I think something like this is what was desired: 
|
|
This will pass if gem release is done (i don't have perms): 
|
aguilinger
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PRs (2 of 2 merged on API layer, aptible-api-ruby needs merge+ release before this can move forward)Specs pending some signoff from alex on this one (in terms of desired behavior), backed up by Ann on thisOnly pending a released gem, and should be mergablenote/suggestion - I think we should just add a simple helper whenever someone runs apps/databases (where we say at the bottom, to restart your app, just do
aptible restart --app $IDor whatnotwe might have to add a warning:
"You will only be able to see scheduled maintenance in Environments for which you have been granted at least Read access"databases proof:
apps proof:
The ticket asked for this grouping (which I can do) if desired, but felt that this was a bit easier to view (and has more relevant information with ids, which i think our CLI supports instead of handle alone).
I also did not add it to the parent apps (which I can do if desired):
# aptible apps --requiring-maintenance === scantests 2023-07-19 23:00 UTC ubuntu-22 2023-08-01 23:00 UTC debian-9 === security 2023-08-01 23:00 UTC security-notifications-to-shortcut