Support influxdbv2 in custom metric drain #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #17736: Enable "influxdb (anywhere)" (influxdb type) logdrains. |
mdelaossa
force-pushed
the
sc-17736
branch
2 times, most recently
from
c8b8b2a
to
12c6099
Compare
UserNotFound
requested changes
Aug 21, 2023
| - "2.4" | ||
| - "2.5" | ||
| - "2.6" | ||
| - "2.7" |
There was a problem hiding this comment.
The Toolbelt still uses 2.3, so we can't stop testing it.
$ /opt/aptible-toolbelt/embedded/bin/ruby --version
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin19]
There was a problem hiding this comment.
sadface, I'll see what I can do to get BigNumber behaving
There was a problem hiding this comment.
finally figured it out - it was Bundler that was the biggest pain
mdelaossa
force-pushed
the
sc-17736
branch
4 times, most recently
from
ea8bc4b
to
59bb720
Compare
mdelaossa
force-pushed
the
sc-17736
branch
2 times, most recently
from
8178db9
to
04094ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command,
metric_drain:create:influxdb:customv2Requires https://github.com/aptible/deploy-api/pull/1223