Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkMethod relative symlink #1092

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vkaylee
Copy link

@vkaylee vkaylee commented Jul 5, 2022

It may relate to Fixes #783

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Guide here
Add linkMehod: absoluteSymlink, relativeSymlink

The default one is symlink. It will be treated as absoluteSymlink

Add to the document. Pull request here aptly-dev/www.aptly.info#98

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (f0a85b2) to head (2d37175).
Report is 478 commits behind head on master.

Files with missing lines Patch % Lines
files/package_pool.go 76.92% 2 Missing and 1 partial ⚠️
files/public.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
- Coverage   66.31%   66.31%   -0.01%     
==========================================
  Files         141      141              
  Lines       15890    15906      +16     
==========================================
+ Hits        10538    10548      +10     
- Misses       4603     4606       +3     
- Partials      749      752       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randombenj
Copy link
Contributor

@vleedev failing tests should be fixed now, would you mind rebasing?

@vkaylee
Copy link
Author

vkaylee commented Jul 13, 2022

@vleedev failing tests should be fixed now, would you mind rebasing?

It has been rebased. Could you trigger CI?

@randombenj
Copy link
Contributor

Generally the changes look good, so thanks for your contribution!
Two things however:

  • absoluteSymlink does not seem to work, it will create a hardlink, only symlink works, could you have a look at that
  • The rebasing seems to have gone wild, there are some commits from master also in this branch now, could you maybe fix this as well?

@randombenj
Copy link
Contributor

Close due to inactivity ...

@randombenj randombenj closed this May 1, 2023
@neolynx neolynx removed the request for review from randombenj April 24, 2024 19:54
@neolynx neolynx self-assigned this Apr 24, 2024
@neolynx neolynx reopened this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when publishing, use relative symbolic links
3 participants