Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename StacklessControlFlowGraph::is_dummmy() to is_dummy() #10501

Merged
merged 1 commit into from
Nov 16, 2023
Merged

rename StacklessControlFlowGraph::is_dummmy() to is_dummy() #10501

merged 1 commit into from
Nov 16, 2023

Conversation

aquynh
Copy link
Contributor

@aquynh aquynh commented Oct 13, 2023

Description

rename StacklessControlFlowGraph::is_dummmy() to is_dummy()

Test Plan

This is just a fix for typo in a function name.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50b1a64) 68.6% compared to head (77798f3) 68.9%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #10501     +/-   ##
=========================================
+ Coverage    68.6%    68.9%   +0.3%     
=========================================
  Files         749      749             
  Lines      172055   172055             
=========================================
+ Hits       118172   118694    +522     
+ Misses      53883    53361    -522     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brmataptos brmataptos enabled auto-merge (squash) November 16, 2023 18:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848

Compatibility test results for aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5316 txn/s, latency: 6354 ms, (p50: 6600 ms, p90: 9200 ms, p99: 15000 ms), latency samples: 191400
2. Upgrading first Validator to new version: 77798f3da46aefe3a4bc6c47a7f6ca81f424f848
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1786 txn/s, latency: 16449 ms, (p50: 18900 ms, p90: 22400 ms, p99: 22600 ms), latency samples: 92920
3. Upgrading rest of first batch to new version: 77798f3da46aefe3a4bc6c47a7f6ca81f424f848
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1586 txn/s, latency: 17297 ms, (p50: 19500 ms, p90: 23700 ms, p99: 25300 ms), latency samples: 80900
4. upgrading second batch to new version: 77798f3da46aefe3a4bc6c47a7f6ca81f424f848
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3708 txn/s, latency: 8683 ms, (p50: 9900 ms, p90: 12000 ms, p99: 12300 ms), latency samples: 144620
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 77798f3da46aefe3a4bc6c47a7f6ca81f424f848

two traffics test: inner traffic : committed: 8303 txn/s, latency: 4736 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10800 ms), latency samples: 3579000
two traffics test : committed: 100 txn/s, latency: 2292 ms, (p50: 2200 ms, p90: 2600 ms, p99: 5600 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.204, avg: 0.196", "QsPosToProposal: max: 0.158, avg: 0.146", "ConsensusProposalToOrdered: max: 0.586, avg: 0.568", "ConsensusOrderedToCommit: max: 0.507, avg: 0.479", "ConsensusProposalToCommit: max: 1.068, avg: 1.046"]
Max round gap was 1 [limit 4] at version 1323429. Max no progress secs was 4.237475 [limit 10] at version 1323429.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848

Compatibility test results for aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848 (PR)
Upgrade the nodes to version: 77798f3da46aefe3a4bc6c47a7f6ca81f424f848
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 6946 txn/s, latency: 4795 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8300 ms), latency samples: 243120
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 77798f3da46aefe3a4bc6c47a7f6ca81f424f848 passed
Test Ok

@gregnazario gregnazario disabled auto-merge November 16, 2023 19:43
@gregnazario gregnazario merged commit a21c676 into aptos-labs:main Nov 16, 2023
70 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants