Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move example] Add a claim_list module example for efficiently managing a claim list #11496

Closed
wants to merge 1 commit into from

Conversation

movekevin
Copy link
Contributor

Description

Test Plan

Copy link

trunk-io bot commented Dec 22, 2023

⏱️ 3h 31m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 1h 18m 🟩🟩🟩🟩
rust-unit-tests 1h 7m 🟩🟩
run-tests-main-branch 20m 🟩🟩🟩🟩
rust-lints 19m 🟥🟩🟩
check 9m 🟥🟩🟩
general-lints 8m 🟩🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
file_change_determinator 43s 🟩🟩🟩🟩
file_change_determinator 28s 🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +37%

settingsfeedbackdocs ⋅ learn more about trunk.io

@movekevin movekevin force-pushed the efficient-mint branch 2 times, most recently from 1a8bafc to a78d7a9 Compare December 22, 2023 20:31

struct ClaimList has key {
// Key can also be replaced with address if the claim_list is tracked by user addresses.
codes_claimed: SmartTable<u64, bool>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put a comment here to compare to smart vector

Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Feb 6, 2024
@github-actions github-actions bot removed the Stale label Feb 20, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@github-actions github-actions bot closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants