[compiler-v2] Fixes an issue in post-processing of exp_builder #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11499 +/- ##
=======================================
Coverage 69.0% 69.0%
=======================================
Files 768 768
Lines 178793 178794 +1
=======================================
+ Hits 123391 123422 +31
+ Misses 55402 55372 -30 ☔ View full report in Codecov by Sentry. |
rahxephon89
approved these changes
Dec 22, 2023
brmataptos
approved these changes
Dec 22, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
During building of expressions, placeholders are used for expressions which can't be decided because of incomplete type inference. At the end when inference is complete, a post processing phase is run to replace those placeholders. This uses the expression rewriter, but that one doesn't descend on rewrite steps. This adds a new `RewrittenAndDescend` variant to rewrite functions which instructs the rewriter to descend on rewritten exps. Fortunately, this is cleanly possible because we not longer use `Result` as a return value. Adds one test case which exposed this behavior from `simple_map` in the stdlib.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
❌ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During building of expressions, placeholders are used for expressions which can't be decided because of incomplete type inference. At the end when inference is complete, a post processing phase is run to replace those placeholders. This uses the expression rewriter, but that one doesn't descend on rewrite steps.
This adds a new
RewrittenAndDescendvariant to rewrite functions which instructs the rewriter to descend on rewritten exps. Fortunately, this is cleanly possible because we not longer useResultas a return value.Adds one test case which exposed this behavior from
simple_mapin the aptos stdlib.