-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Node Startup Config] Add ability to skip optimizer/sanitizer. #11502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLind
requested review from
brianolson,
bchocho,
ibalajiarun and
perryjrandall
December 22, 2023 22:50
perryjrandall
approved these changes
Dec 22, 2023
grao1991
approved these changes
Jan 11, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
config_san_skip
branch
from
January 11, 2024 23:26
84627e7
to
24ee255
Compare
JoshLind
force-pushed
the
config_san_skip
branch
from
January 12, 2024 02:24
24ee255
to
59d7114
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
❌ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to skip the node config optimizer and sanitizer on node startup. To achieve this, we add a new
NodeStartupConfig
which is used to determine if either step should be skipped. To disable sanitization and optimization, one would add this to their node config:The PR offers several commits:
netbench.rs
file tonetbench_config.rs
(for consistency -- all other files follow this format).NodeStartupConfig
functionality and some small unit tests.Test Plan
New and existing test infrastructure.