Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] increase load of graceful overload #15159

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[forge] increase load of graceful overload #15159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testsuite/forge-cli/src/suites/realistic_environment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ pub(crate) fn realistic_env_graceful_overload(duration: Duration) -> ForgeConfig
.with_initial_fullnode_count(20)
.add_network_test(wrap_with_realistic_env(num_validators, TwoTrafficsTest {
inner_traffic: EmitJobRequest::default()
.mode(EmitJobMode::ConstTps { tps: 15000 })
.mode(EmitJobMode::ConstTps { tps: 30000 })
Copy link
Contributor

@vusirikala vusirikala Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the TPS is increased, should we be updating the success criteria for the test as well?
Is the test already passing with the current success criteria?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was passing "too well" -- almost at 14K TPS. Now that we've made it overload, it is at 11K TPS. To avoid test failure noise, I'll change the success criteria after we see a few runs though

.init_gas_price_multiplier(20),
inner_success_criteria: SuccessCriteria::new(7500),
}))
Expand Down
Loading