Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] forge stable bug fixes #15161

Merged
merged 3 commits into from
Nov 2, 2024
Merged

[forge] forge stable bug fixes #15161

merged 3 commits into from
Nov 2, 2024

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Nov 1, 2024

Description

  • Fix parallelism param bug that prevented the workflow from running on schedule trigger
  • If a test doesn't need failpoints or performance image, no need to check for it and use a older image.
  • Set concurrency level for dispatch trigger based on git SHA so it doesn't interfere with multiple workflow runs on same ref.

Copy link

trunk-io bot commented Nov 1, 2024

⏱️ 1h 41m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
determine-test-metadata 21m 🟩🟩🟩🟩🟩 (+8 more)
rust-cargo-deny 17m 🟩🟩🟩🟩 (+5 more)
check-dynamic-deps 15m 🟩🟩🟩🟩🟩 (+5 more)
rust-doc-tests 5m 🟩
general-lints 5m 🟩🟩🟩🟩🟩 (+5 more)
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 2m
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 24m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun force-pushed the balaji/forge-stable-images branch 4 times, most recently from a0f70f9 to 3e39b62 Compare November 1, 2024 22:21
@ibalajiarun ibalajiarun changed the title [forge] check for necessary images only [forge] forge stable bug fixes Nov 1, 2024
@ibalajiarun ibalajiarun force-pushed the balaji/forge-stable-images branch from 323bfa9 to e0d2398 Compare November 1, 2024 22:46
@ibalajiarun ibalajiarun marked this pull request as ready for review November 1, 2024 22:46
@ibalajiarun ibalajiarun requested a review from a team as a code owner November 1, 2024 22:46
@ibalajiarun ibalajiarun requested review from bchocho and a team November 1, 2024 22:46
@ibalajiarun ibalajiarun enabled auto-merge (squash) November 1, 2024 23:53

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite realistic_env_max_load success on e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562

two traffics test: inner traffic : committed: 14322.84 txn/s, latency: 2772.77 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5445860
two traffics test : committed: 99.99 txn/s, latency: 1799.22 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 10500 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.016, avg: 1.490", "ConsensusProposalToOrdered: max: 0.328, avg: 0.294", "ConsensusOrderedToCommit: max: 0.371, avg: 0.351", "ConsensusProposalToCommit: max: 0.663, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.97s no progress at version 2124517 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.65s no progress at version 2124515 (avg 7.11s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite framework_upgrade success on 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562

Compatibility test results for 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562 (PR)
Upgrade the nodes to version: e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1299.87 txn/s, submitted: 1302.52 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2407.98 ms, (p50: 2100 ms, p70: 2400, p90: 3800 ms, p99: 5100 ms), latency samples: 117920
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1219.17 txn/s, submitted: 1221.85 txn/s, failed submission: 2.68 txn/s, expired: 2.68 txn/s, latency: 2455.02 ms, (p50: 2100 ms, p70: 2500, p90: 4500 ms, p99: 6000 ms), latency samples: 109040
5. check swarm health
Compatibility test for 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562 passed
Upgrade the remaining nodes to version: e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1275.68 txn/s, submitted: 1278.19 txn/s, failed submission: 2.51 txn/s, expired: 2.51 txn/s, latency: 2379.12 ms, (p50: 1800 ms, p70: 2400, p90: 4500 ms, p99: 6600 ms), latency samples: 111960
Test Ok

Copy link
Contributor

github-actions bot commented Nov 2, 2024

✅ Forge suite compat success on 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562

Compatibility test results for 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562 (PR)
1. Check liveness of validators at old version: 641ccd865fb3fe61699219aa0968d86101623353
compatibility::simple-validator-upgrade::liveness-check : committed: 14419.87 txn/s, latency: 2058.16 ms, (p50: 1900 ms, p70: 2000, p90: 2400 ms, p99: 7700 ms), latency samples: 551900
2. Upgrading first Validator to new version: e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6540.95 txn/s, latency: 4316.35 ms, (p50: 4700 ms, p70: 4900, p90: 5500 ms, p99: 5900 ms), latency samples: 128380
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6923.25 txn/s, latency: 4682.93 ms, (p50: 5000 ms, p70: 5100, p90: 6400 ms, p99: 6900 ms), latency samples: 233180
3. Upgrading rest of first batch to new version: e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6746.22 txn/s, latency: 4197.64 ms, (p50: 4800 ms, p70: 5200, p90: 5200 ms, p99: 5300 ms), latency samples: 123120
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6905.07 txn/s, latency: 4673.53 ms, (p50: 5100 ms, p70: 5200, p90: 5500 ms, p99: 5700 ms), latency samples: 237500
4. upgrading second batch to new version: e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6964.10 txn/s, latency: 3884.26 ms, (p50: 4000 ms, p70: 4800, p90: 5200 ms, p99: 5900 ms), latency samples: 141180
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6515.94 txn/s, latency: 4877.63 ms, (p50: 4500 ms, p70: 5100, p90: 9100 ms, p99: 10700 ms), latency samples: 213220
5. check swarm health
Compatibility test for 641ccd865fb3fe61699219aa0968d86101623353 ==> e0d2398d89c80a2a5b5a0d2c8a9d8e70635a7562 passed
Test Ok

@ibalajiarun ibalajiarun merged commit 4f3262d into main Nov 2, 2024
91 checks passed
@ibalajiarun ibalajiarun deleted the balaji/forge-stable-images branch November 2, 2024 00:25
bchocho pushed a commit that referenced this pull request Nov 4, 2024
* [forge] check for necessary images only

* [gha] fix forge stable parallelism bug

* set name for run step as forge test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants