Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Remove hardhat on Move #15462

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[move] Remove hardhat on Move #15462

merged 1 commit into from
Jan 14, 2025

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Dec 3, 2024

Description

We do not need hardhat on Move.

  1. No one work or will work on this in the near future.
  2. If ecosystem builds things, it is better that we keep move repo small and nice, and things like "move-on-evm" are built around. Otherwise we end up changing Move in order to make sure EVM things work (which is the case of V1 compiler, and its EVM and async flavours)
  3. Even if we want to keep Move to yul, etc., hardhat is really not needed, + we have Aptos workspace.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 3, 2024

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 40s 🟩
general-lints 31s 🟩
semgrep/ci 20s 🟩
file_change_determinator 14s 🟩
permission-check 4s 🟩
permission-check 2s 🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Dec 3, 2024

@georgemitenkov georgemitenkov marked this pull request as ready for review December 3, 2024 15:42
@georgemitenkov georgemitenkov force-pushed the george/move-on-aptos-fixes branch from b020c0c to e88cfa2 Compare December 5, 2024 18:35
Base automatically changed from george/move-on-aptos-fixes to main December 5, 2024 19:08
Copy link
Contributor

@wrwg wrwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pity to see this be slayed, but we can always get it back from the history if needed.

@georgemitenkov georgemitenkov enabled auto-merge (squash) January 14, 2025 17:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 2cad4144de8d9742753503a1be4132cf8bf07a92

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 2cad4144de8d9742753503a1be4132cf8bf07a92 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17673.02 txn/s, latency: 1959.48 ms, (p50: 2000 ms, p70: 2100, p90: 2300 ms, p99: 3500 ms), latency samples: 572620
2. Upgrading first Validator to new version: 2cad4144de8d9742753503a1be4132cf8bf07a92
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5205.05 txn/s, latency: 5940.92 ms, (p50: 6800 ms, p70: 7200, p90: 7300 ms, p99: 7600 ms), latency samples: 102920
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5199.02 txn/s, latency: 6618.45 ms, (p50: 7300 ms, p70: 7400, p90: 7700 ms, p99: 7800 ms), latency samples: 180540
3. Upgrading rest of first batch to new version: 2cad4144de8d9742753503a1be4132cf8bf07a92
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4939.85 txn/s, latency: 6251.13 ms, (p50: 7100 ms, p70: 7500, p90: 7900 ms, p99: 7900 ms), latency samples: 98600
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4943.33 txn/s, latency: 6980.02 ms, (p50: 7700 ms, p70: 7800, p90: 8100 ms, p99: 8200 ms), latency samples: 175500
4. upgrading second batch to new version: 2cad4144de8d9742753503a1be4132cf8bf07a92
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9265.27 txn/s, latency: 3327.00 ms, (p50: 3900 ms, p70: 4000, p90: 4100 ms, p99: 4200 ms), latency samples: 164720
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9154.34 txn/s, latency: 3731.75 ms, (p50: 4100 ms, p70: 4100, p90: 4200 ms, p99: 4400 ms), latency samples: 300120
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 2cad4144de8d9742753503a1be4132cf8bf07a92 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2cad4144de8d9742753503a1be4132cf8bf07a92

two traffics test: inner traffic : committed: 14479.40 txn/s, latency: 2744.74 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5505380
two traffics test : committed: 99.99 txn/s, latency: 1416.67 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 1700 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.662, avg: 1.606", "ConsensusProposalToOrdered: max: 0.296, avg: 0.293", "ConsensusOrderedToCommit: max: 0.337, avg: 0.328", "ConsensusProposalToCommit: max: 0.630, avg: 0.621"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 991920 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.61s no progress at version 2211363 (avg 0.61s) [limit 16].
Test Ok

@georgemitenkov georgemitenkov merged commit 506903f into main Jan 14, 2025
46 checks passed
@georgemitenkov georgemitenkov deleted the george/remove-hardhat branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants