-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cargo deny lint check #15496
base: main
Are you sure you want to change the base?
Fix cargo deny lint check #15496
Conversation
⏱️ 48m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
.github/workflows/lint-test.yaml
Outdated
@@ -86,7 +86,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v4 | |||
if: needs.file_change_determinator.outputs.only_docs_changed != 'true' | |||
- uses: EmbarkStudios/cargo-deny-action@v1 | |||
- uses: EmbarkStudios/cargo-deny-action@ve2f4ede4a4e60ea15ff31bc0647485d80c66cfba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit hash appears to have an erroneous ve
prefix. The correct hash should be e2f4ede4a4e60ea15ff31bc0647485d80c66cfba
. This small typo will prevent the GitHub action from finding the correct version of the cargo-deny-action.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
7fd8342
to
fb60821
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
This issue is stale because it has been open 45 days with no activity. Remove the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
❌ Forge suite
|
Description
This was broken: https://github.com/aptos-labs/aptos-core/actions/runs/12155333790/job/33897652078?pr=15365. Now it is fixed, see test plan.
How Has This Been Tested?
See successful run: https://github.com/aptos-labs/aptos-core/actions/runs/12168176251/job/33938427453?pr=15496.
Key Areas to Review
N/A
Type of Change
Which Components or Systems Does This Change Impact?
Checklist