Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loader-v2] Fixing global cache reads & read-before-write on publish (#15285) (#15298) #15499

Closed
wants to merge 16 commits into from
Closed

[loader-v2] Fixing global cache reads & read-before-write on publish (#15285) (#15298) #15499

wants to merge 16 commits into from

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

github-actions bot and others added 16 commits November 18, 2024 20:18
@github-actions @georgemitenkov
[loader-v2] Fixing global cache reads & read-before-write on publish (#…
be3ccc5 
…15285) (#15298)

- Enforces read-before-write for module publishes.
- Records all module reads in captured reads, not just per-block.
- Adds a workload + test to publish and call modules.

Co-authored-by: Igor <[email protected]>
(cherry picked from commit 0a16e9e)

Co-authored-by: George Mitenkov <[email protected]>
@msmouse
[cp 1.24] fix deadlock on nested DropHelper (#15326)
7f9825b
@zekun000
[qs] remove assertion on timestamp
058df1b 
(cherry picked from commit 11c4819)
@JoshLind
[Consensus Observer] Add sync lag based fallback.
df3d805
@github-actions @sherry-x
Cherrypick #280 (#282) (#15258) (#15341)
a12510d 
(cherry picked from commit ea6e45f)

Co-authored-by: Sherry Xiao <[email protected]>
@github-actions @georgemitenkov
[loader-v2] Small cleanups & tests (#15279) (#15343)
3e614b2 
- Fixed naming for global module cache.
- Added more counters, moved some old ones.
- Added unit tests for TransactionSliceMetadata + renaming.

(cherry picked from commit 47f0bf3)

Co-authored-by: George Mitenkov <[email protected]>
@github-actions @georgemitenkov
[loader-v2] Addressing TODOs (#15316) (#15342)
a734d23 
- Switching from undefined to script location
- Keeping error remapping because the status code exists on-chain.
   It is probably fine t keep it as is.
- Removed useless TODO for alerts on concurrent manager uses.
- Changed errors.rs TODO into a note, as it is not a P0/P1/P2 to fix.

(cherry picked from commit dbdb613)

Co-authored-by: George Mitenkov <[email protected]>
@msmouse
[cp 1.24] Move payload_manager.notify_commit to after commit (#15362)
327445f
@github-actions @ibalajiarun
[consensus] sync improvements to help slow nodes sync better (#15364) (…
9497626 
…#15377)

* [qs] grace period before GC committed batches

* [consensus] trigger sync based on remote LI timestamp

(cherry picked from commit d672085)

Co-authored-by: Balaji Arun <[email protected]>
@JoshLind
[cp] Temporarily loosen backpressures, until module loading improveme…
f436adb 
…nt speeds up blocks
@vineethk @sherry-x
Fix units in timed feature flags (#15391)
010570d 
(cherry picked from commit 4d4c200)
@ziaptos @sherry-x
followup to a TODO for a constant
fe13df0 
(cherry picked from commit 14cd388)
@ziaptos @sherry-x
followup to a TODO for a constant
da3b3a1 
(cherry picked from commit c522181)
@ziaptos @sherry-x
allowing larger constant for legacy tests
8dfd7b9 
(cherry picked from commit 629850d)
@ziaptos @sherry-x
separating constants
5279eaf 
(cherry picked from commit 2dd6b77)
@JoshLind
[Release] Update release.yaml for v1.24.0 framework release.
3527aa2
@trunk-io Trunk.io
Copy link

trunk-io bot commented Dec 4, 2024 •
edited
Loading

⏱️ 6s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 4s 🟩 
permission-check 2s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@georgemitenkov Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov
Copy link
Contributor Author

georgemitenkov commented Dec 4, 2024 •
edited
Loading

Graphite created a PR by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario will be requested when the pull request is marked ready for review gregnazario is a code owner

@banool banool Awaiting requested review from banool banool will be requested when the pull request is marked ready for review banool is a code owner

@bchocho bchocho Awaiting requested review from bchocho bchocho will be requested when the pull request is marked ready for review bchocho is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash will be requested when the pull request is marked ready for review gelash is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun ibalajiarun will be requested when the pull request is marked ready for review ibalajiarun is a code owner

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind will be requested when the pull request is marked ready for review JoshLind is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl danielxiangzl will be requested when the pull request is marked ready for review danielxiangzl is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@0xmaayan 0xmaayan Awaiting requested review from 0xmaayan 0xmaayan will be requested when the pull request is marked ready for review 0xmaayan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgemitenkov @msmouse @JoshLind @vineethk @ziaptos