Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] Run forge nightly on weekdays #15591

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

perryjrandall
Copy link
Contributor

@perryjrandall perryjrandall commented Dec 13, 2024

Description

Updates the forge-stable workflow schedule to run Monday through Friday at 22:00 UTC instead of only running on Sunday, Tuesday, and Thursday.

How Has This Been Tested?

This change only modifies the GitHub Actions workflow schedule configuration. The functionality of the forge tests remains unchanged.

I will schedule from this PR to ensure that the cron spec is valid

Key Areas to Review

The cron expression syntax: 0 22 * * 1-5 represents:

  • Minutes: 0
  • Hour: 22 (UTC)
  • Day of month: *
  • Month: *
  • Day of week: 1-5 (Monday through Friday)

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 13, 2024

⏱️ 3h 17m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 22m 🟩🟩🟩🟩🟩
test-target-determinator 20m 🟩🟩🟩
forge-framework-upgrade-test / forge 14m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 13m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 8m
check 8m 🟥🟥🟥🟥🟥 (+1 more)
fetch-last-released-docker-image-tag 8m 🟩🟩🟩🟩🟩
determine-test-metadata 7m 🟩🟩🟥🟩🟩
rust-doc-tests 6m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+2 more)
rust-doc-tests 5m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@perryjrandall perryjrandall marked this pull request as ready for review December 16, 2024 18:24
@perryjrandall perryjrandall requested a review from a team as a code owner December 16, 2024 18:24
@perryjrandall perryjrandall force-pushed the 12-12-_forge_run_forge_nightly_on_weekdays branch from bbd9521 to 675b21d Compare December 16, 2024 18:58
@perryjrandall perryjrandall added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 16, 2024
@perryjrandall perryjrandall force-pushed the 12-12-_forge_run_forge_nightly_on_weekdays branch 2 times, most recently from 70aa14c to 73dc2b7 Compare December 16, 2024 20:17
@perryjrandall perryjrandall force-pushed the 12-12-_forge_run_forge_nightly_on_weekdays branch from 73dc2b7 to 5e524d8 Compare December 16, 2024 20:25

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@perryjrandall perryjrandall enabled auto-merge (rebase) December 16, 2024 22:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba (PR)
1. Check liveness of validators at old version: 34025227eb5367c449bf9dae3cd226fe5c187904
compatibility::simple-validator-upgrade::liveness-check : committed: 16023.90 txn/s, latency: 2060.32 ms, (p50: 2100 ms, p70: 2200, p90: 2400 ms, p99: 3300 ms), latency samples: 537880
2. Upgrading first Validator to new version: 5e524d8eb2620bb8080985d5f48993a6acc74eba
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7262.04 txn/s, latency: 3942.06 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 136680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7305.71 txn/s, latency: 4411.58 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 247540
3. Upgrading rest of first batch to new version: 5e524d8eb2620bb8080985d5f48993a6acc74eba
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6917.98 txn/s, latency: 4110.11 ms, (p50: 4500 ms, p70: 4900, p90: 5000 ms, p99: 5000 ms), latency samples: 128280
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7228.52 txn/s, latency: 4575.52 ms, (p50: 5000 ms, p70: 5100, p90: 5100 ms, p99: 5400 ms), latency samples: 240860
4. upgrading second batch to new version: 5e524d8eb2620bb8080985d5f48993a6acc74eba
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12010.15 txn/s, latency: 2232.54 ms, (p50: 2100 ms, p70: 2700, p90: 3200 ms, p99: 3400 ms), latency samples: 210880
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12635.94 txn/s, latency: 2455.98 ms, (p50: 2200 ms, p70: 3000, p90: 3200 ms, p99: 3400 ms), latency samples: 413320
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5e524d8eb2620bb8080985d5f48993a6acc74eba

two traffics test: inner traffic : committed: 14688.48 txn/s, latency: 2706.71 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5584880
two traffics test : committed: 99.93 txn/s, latency: 1376.95 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2200 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.588, avg: 1.557", "ConsensusProposalToOrdered: max: 0.332, avg: 0.295", "ConsensusOrderedToCommit: max: 0.308, avg: 0.299", "ConsensusProposalToCommit: max: 0.600, avg: 0.594"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 12425 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.58s no progress at version 2201897 (avg 0.58s) [limit 16].
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba (PR)
Upgrade the nodes to version: 5e524d8eb2620bb8080985d5f48993a6acc74eba
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 973.45 txn/s, submitted: 1002.42 txn/s, failed submission: 1.33 txn/s, expired: 28.97 txn/s, latency: 2696.00 ms, (p50: 2100 ms, p70: 2400, p90: 3200 ms, p99: 11800 ms), latency samples: 87826
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1363.32 txn/s, submitted: 1365.14 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2287.17 ms, (p50: 2300 ms, p70: 2400, p90: 3000 ms, p99: 3800 ms), latency samples: 119980
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 5e524d8eb2620bb8080985d5f48993a6acc74eba passed
Upgrade the remaining nodes to version: 5e524d8eb2620bb8080985d5f48993a6acc74eba
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1238.97 txn/s, submitted: 1240.95 txn/s, failed submission: 1.98 txn/s, expired: 1.98 txn/s, latency: 2353.34 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5400 ms), latency samples: 112560
Test Ok

@perryjrandall perryjrandall merged commit 38a5f0d into main Dec 18, 2024
92 checks passed
@perryjrandall perryjrandall deleted the 12-12-_forge_run_forge_nightly_on_weekdays branch December 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants